add wait_for_startup to base controller #308
Open
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
==========================================
- Coverage 90.69% 90.52% -0.17%
==========================================
Files 70 70
Lines 2535 2544 +9
==========================================
+ Hits 2299 2303 +4
- Misses 236 241 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GDYendell
reviewed
Jan 22, 2026
| """Wait for the controller to be fully started. | ||
| This method blocks until the controller has completed post_initialise, | ||
| making it ready for use. |
Contributor
There was a problem hiding this comment.
This does not appear to be true - it times out and returns False. I think we probably want it to propagate the exception. If it times out what is the caller supposed to do other than stop the application?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GDYendell as discussed yesterday. This is working as expected for fastcs-catio.